Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoeyBwAJ

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org

Committed: https://crrev.com/0ac96023be4cd86fec7404752ea61c7d6ede5ab0
Cr-Commit-Position: refs/heads/master@{#391951}

[jsbell, 2016-05-02 21:11:59]

Description was changed from

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org
==========

to

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoey...

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org
==========

[jsbell, 2016-05-04 18:24:19]

mpearson@, rbyers@ - please take a look?

[Mark P, 2016-05-04 18:45:45]

histograms.xml lgtm

[Rick Byers, 2016-05-04 20:42:18]

LGTM with a couple minor nit / suggestions

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1153:
URL_Method_RevokeObjectURL_ServiceWorker = 1335,
nit: I think these underscore-style tokens are generally auto-generated by the
[Measure]/[Deprecate] custom attributes.  When hand-defining our own tokens (as
you're doing here) I think we always use CamelCase style.

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp (right):

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp:45: if
(executionContext && executionContext->isServiceWorkerGlobalScope())
nit: you could eliminate some redundancy by adding a
Deprecation::countDeprecationServiceWorker method similar to the other
countDeprecation* methods.  Minor though - up to you.

[jsbell, 2016-05-04 21:41:46]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-05-04 21:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1938183002/#ps60001
(title: "Drop underscores in enum")

[commit-bot: I haz the power, 2016-05-04 21:42:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938183002/60001

[commit-bot: I haz the power, 2016-05-04 21:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:45:55]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jsbell, 2016-05-04 23:05:57]

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1153:
URL_Method_RevokeObjectURL_ServiceWorker = 1335,
On 2016/05/04 20:42:18, Rick Byers wrote:
> nit: I think these underscore-style tokens are generally auto-generated by the
> [Measure]/[Deprecate] custom attributes.  When hand-defining our own tokens
(as
> you're doing here) I think we always use CamelCase style.

Done. (That's what I get for turning off my brain.)

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp (right):

https://codereview.chromium.org/1938183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp:45: if
(executionContext && executionContext->isServiceWorkerGlobalScope())
On 2016/05/04 20:42:18, Rick Byers wrote:
> nit: you could eliminate some redundancy by adding a
> Deprecation::countDeprecationServiceWorker method similar to the other
> countDeprecation* methods.  Minor though - up to you.

Noted - given that this is temporary (famous last words...), leaving this as-is.

[jsbell, 2016-05-04 23:06:05]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-05-04 23:06:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1938183002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-04 23:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938183002/80001

[commit-bot: I haz the power, 2016-05-04 23:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 23:19:49]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[jsbell, 2016-05-05 16:19:35]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-05-05 16:19:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1938183002/#ps100001
(title: "derp")

[commit-bot: I haz the power, 2016-05-05 16:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938183002/100001

[commit-bot: I haz the power, 2016-05-05 21:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 21:55:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jsbell, 2016-05-05 21:59:43]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-05-05 22:00:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1938183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1938183002/100001

[commit-bot: I haz the power, 2016-05-05 23:44:19]

Description was changed from

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoey...

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org
==========

to

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoey...

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org
==========

[commit-bot: I haz the power, 2016-05-05 23:44:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-05 23:45:29]

Description was changed from

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoey...

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org
==========

to

==========
Deprecate URL.createObjectURL/revokeObjectURL in Service Workers

As a prelude to removal of these methods, slip a deprecation warning in.

Intent Thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HuA7Ng9U0oc/CYvfMoey...

BUG=604951
R=rbyers@chromium.org,mpearson@chromium.org

Committed: https://crrev.com/0ac96023be4cd86fec7404752ea61c7d6ede5ab0
Cr-Commit-Position: refs/heads/master@{#391951}
==========

[commit-bot: I haz the power, 2016-05-05 23:45:30]

Patchset 6 (id:??) landed as
https://crrev.com/0ac96023be4cd86fec7404752ea61c7d6ede5ab0
Cr-Commit-Position: refs/heads/master@{#391951}