Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/dom/DOMURL.cpp

Issue 1953413002: Deprecate URL.createObjectURL/revokeObjectURL in Service Workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/DOMURL.cpp
diff --git a/third_party/WebKit/Source/core/dom/DOMURL.cpp b/third_party/WebKit/Source/core/dom/DOMURL.cpp
index 1b1373b96f9ef4f977f6d0c17e8fd3e6b5227c86..72e0782f482f47fc92e7402331cbb4a409243332 100644
--- a/third_party/WebKit/Source/core/dom/DOMURL.cpp
+++ b/third_party/WebKit/Source/core/dom/DOMURL.cpp
@@ -33,6 +33,8 @@
#include "core/dom/URLSearchParams.h"
#include "core/fetch/MemoryCache.h"
#include "core/fileapi/Blob.h"
+#include "core/frame/Deprecation.h"
+#include "core/frame/UseCounter.h"
#include "core/html/PublicURLManager.h"
#include "platform/blob/BlobURL.h"
#include "platform/weborigin/SecurityOrigin.h"
@@ -88,6 +90,10 @@ String DOMURL::createObjectURL(ExecutionContext* executionContext, Blob* blob, E
DCHECK(blob);
if (!executionContext)
return String();
+
+ if (executionContext->isServiceWorkerGlobalScope())
+ Deprecation::countDeprecation(executionContext, UseCounter::URLMethodCreateObjectURLServiceWorker);
+
if (blob->hasBeenClosed()) {
exceptionState.throwDOMException(InvalidStateError, String(blob->isFile() ? "File" : "Blob") + " has been closed.");
return String();
@@ -111,6 +117,9 @@ void DOMURL::revokeObjectURL(ExecutionContext* executionContext, const String& u
if (!executionContext)
return;
+ if (executionContext->isServiceWorkerGlobalScope())
+ Deprecation::countDeprecation(executionContext, UseCounter::URLMethodRevokeObjectURLServiceWorker);
+
KURL url(KURL(), urlString);
executionContext->removeURLFromMemoryCache(url);
executionContext->publicURLManager().revoke(url);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698