Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1953323002: Don't allow scripts to run when a node is being adopted. (Closed)

Created:
3 years, 7 months ago by Martin Barbella
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Don't allow scripts to run when a node is being adopted. Running a script in the middle of rescoping nodes can break a lot of invariants and leave DOM in an inconsistent state. This patch adds a ScriptForbiddenScope in TreeScope::adoptIfNeeded to ensure it never happens. BUG=605766 Review URL: https://codereview.chromium.org/1910403003 Cr-Commit-Position: refs/heads/master@{#389425} (cherry picked from commit 146ff1bb11c88778d466bd7a49b544f2b5806ee0) TBR=dominicc@chromium.org,esprehn@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/73dd06077821b2beba42165c484913601d9e8643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Martin Barbella
Committed patchset #1 (id:1) manually as 73dd06077821b2beba42165c484913601d9e8643.
3 years, 7 months ago (2016-05-06 19:35:17 UTC) #2
dominicc (has gone to gerrit)
3 years, 7 months ago (2016-05-07 15:27:43 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698