third_party/WebKit/Source/core/dom/TreeScope.cpp - Issue 1953323002: Don't allow scripts to run when a node is being adopted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TreeScope.cpp

Issue 1953323002: Don't allow scripts to run when a node is being adopted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/TreeScope.cpp

diff --git a/third_party/WebKit/Source/core/dom/TreeScope.cpp b/third_party/WebKit/Source/core/dom/TreeScope.cpp

index 59ea10298501e83b20164658595f8ea69838ba58..6133bf66495a2691dd1bfe9e140c356ae617f93f 100644

--- a/third_party/WebKit/Source/core/dom/TreeScope.cpp

+++ b/third_party/WebKit/Source/core/dom/TreeScope.cpp

@@ -415,8 +415,10 @@ void TreeScope::adoptIfNeeded(Node& node)

ASSERT_WITH_SECURITY_IMPLICATION(!node.m_deletionHasBegun);

#endif

TreeScopeAdopter adopter(node, *this);

- if (adopter.needsScopeChange())

+ if (adopter.needsScopeChange()) {

+ ScriptForbiddenScope forbidScript;

adopter.execute();

+ }

}

Element* TreeScope::adjustedFocusedElement() const

« no previous file with comments | « no previous file | no next file » | no next file with comments »