Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957713003: EDK: Remove Core::GetDispatcher(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work789_edk_handle_table_14-x-work788_edk_handle_13.9-x-work787_edk_handle_13.8
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M mojo/edk/embedder/embedder.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/edk/system/core.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M mojo/edk/system/handle.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_unittest.cc View 1 chunk +31 lines, -0 lines 1 comment Download

Depends on Patchset:

Issue 1953293003 Patch 1

Dependent Patchsets:

Issue 1957763002 Patch 1

Messages

Total messages: 8 (3 generated)
viettrungluu
Depends on https://codereview.chromium.org/1953293003/.
4 years, 7 months ago (2016-05-06 19:58:58 UTC) #1
viettrungluu
+azani, if he's around
4 years, 7 months ago (2016-05-09 17:38:17 UTC) #3
azani
lgtm https://codereview.chromium.org/1957713003/diff/1/mojo/edk/system/handle_unittest.cc File mojo/edk/system/handle_unittest.cc (right): https://codereview.chromium.org/1957713003/diff/1/mojo/edk/system/handle_unittest.cc#newcode120 mojo/edk/system/handle_unittest.cc:120: nit: Maybe add a test for for MOJO_HANDLE_RIGHT_NONE
4 years, 7 months ago (2016-05-09 21:52:24 UTC) #4
viettrungluu
Thanks. On 2016/05/09 21:52:24, azani wrote: > lgtm > > https://codereview.chromium.org/1957713003/diff/1/mojo/edk/system/handle_unittest.cc > File mojo/edk/system/handle_unittest.cc (right): ...
4 years, 7 months ago (2016-05-09 23:08:40 UTC) #6
viettrungluu
4 years, 7 months ago (2016-05-09 23:11:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
badfd682958bea7aed7ba345981bb6d90f9a14fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698