MD Settings: Hooking up router to navigate to dummy About page.

MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/help
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5549c8fb886e128e4114154ff6105883eacfc71b
Cr-Commit-Position: refs/heads/master@{#391961}

[dpapad, 2016-05-05 18:55:19]

Description was changed from

==========
MD Settings: Hooking up router to navigate to dummy About page.

BUG=603625
==========

to

==========
MD Settings: Hooking up router to navigate to dummy About page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-05 19:14:42]

Description was changed from

==========
MD Settings: Hooking up router to navigate to dummy About page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/about
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-05 19:33:25]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-05-05 19:33:25]

Screenshot at http://imgur.com/BH8FxdE.

[dschuyler, 2016-05-05 21:58:21]

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:49: /**
@private */
nit:
@param {SettingsRoute} newRoute blah blah.

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:50:
currentRouteChanged_: function(newRoute, oldRoute) {
Let's remove oldRoute (or add an @param for it,
but it's not used and we commonly leave off the
second param from changed handlers).

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_router.js:99: url:
'/about',
It looks like the legacy url is /help.

[dpapad, 2016-05-05 22:13:54]

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:49: /**
@private */
On 2016/05/05 at 21:58:20, dschuyler wrote:
> nit:
> @param {SettingsRoute} newRoute blah blah.

Done.

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:50:
currentRouteChanged_: function(newRoute, oldRoute) {
On 2016/05/05 at 21:58:20, dschuyler wrote:
> Let's remove oldRoute (or add an @param for it,
> but it's not used and we commonly leave off the
> second param from changed handlers).

Done.

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_router.js (right):

https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_router.js:99: url:
'/about',
On 2016/05/05 at 21:58:20, dschuyler wrote:
> It looks like the legacy url is /help.

Done.

BTW, If we want to be 100% consistent with the old URL, there is more work to be
done.
Current: chrome://md-settings/help
Old: chrome://help

I prefer to leave this work for later, after the about page is implemented.

[dschuyler, 2016-05-05 22:19:28]

lgtm

[dpapad, 2016-05-05 22:28:15]

Description was changed from

==========
MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/about
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/help
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-05-05 22:28:21]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-05-05 22:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953093002/40001

[commit-bot: I haz the power, 2016-05-06 00:21:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-06 00:22:25]

Description was changed from

==========
MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/help
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hooking up router to navigate to dummy About page.

Clicking on "About" in the menu updates URL to chrome://md-settings/help
and displays (for now) a dummy un-styled page.

BUG=603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5549c8fb886e128e4114154ff6105883eacfc71b
Cr-Commit-Position: refs/heads/master@{#391961}
==========

[commit-bot: I haz the power, 2016-05-06 00:22:26]

Patchset 3 (id:??) landed as
https://crrev.com/5549c8fb886e128e4114154ff6105883eacfc71b
Cr-Commit-Position: refs/heads/master@{#391961}