Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed)

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Hooking up router to navigate to dummy About page. Clicking on "About" in the menu updates URL to chrome://md-settings/help and displays (for now) a dummy un-styled page. BUG=603625 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5549c8fb886e128e4114154ff6105883eacfc71b Cr-Commit-Position: refs/heads/master@{#391961}

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 6

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 2 1 chunk +15 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dpapad
Screenshot at http://imgur.com/BH8FxdE.
4 years, 7 months ago (2016-05-05 19:33:25 UTC) #4
dschuyler
https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js#newcode49 chrome/browser/resources/settings/settings_main/settings_main.js:49: /** @private */ nit: @param {SettingsRoute} newRoute blah blah. ...
4 years, 7 months ago (2016-05-05 21:58:21 UTC) #5
dpapad
https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/1953093002/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js#newcode49 chrome/browser/resources/settings/settings_main/settings_main.js:49: /** @private */ On 2016/05/05 at 21:58:20, dschuyler wrote: ...
4 years, 7 months ago (2016-05-05 22:13:54 UTC) #6
dpapad
4 years, 7 months ago (2016-05-05 22:13:57 UTC) #7
dschuyler
lgtm
4 years, 7 months ago (2016-05-05 22:19:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953093002/40001
4 years, 7 months ago (2016-05-05 22:29:05 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 00:21:21 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 00:22:26 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5549c8fb886e128e4114154ff6105883eacfc71b
Cr-Commit-Position: refs/heads/master@{#391961}

Powered by Google App Engine
This is Rietveld 408576698