Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://md-settings/advanced_page/advanced_page.html"> 2 <link rel="import" href="chrome://md-settings/advanced_page/advanced_page.html">
3 <link rel="import" href="chrome://md-settings/basic_page/basic_page.html"> 3 <link rel="import" href="chrome://md-settings/basic_page/basic_page.html">
4 4
5 <dom-module id="settings-main"> 5 <dom-module id="settings-main">
6 <link rel="import" type="css" href="settings_main.css"> 6 <link rel="import" type="css" href="settings_main.css">
7 <template> 7 <template>
8 <content select="paper-icon-button"></content> 8 <content select="paper-icon-button"></content>
9 <div id="pageContainer"> 9 <div id="pageContainer">
10 <template is="dom-if" if="[[!showAdvancedPage_]]"> 10 <template is="dom-if" if="[[showBasicPage_]]">
11 <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}"> 11 <settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
12 </settings-basic-page> 12 </settings-basic-page>
13 </template> 13 </template>
14 <template is="dom-if" if="[[showAdvancedPage_]]"> 14 <template is="dom-if" if="[[showAdvancedPage_]]">
15 <settings-advanced-page prefs="{{prefs}}" 15 <settings-advanced-page prefs="{{prefs}}"
16 current-route="{{currentRoute}}"> 16 current-route="{{currentRoute}}">
17 </settings-advanced-page> 17 </settings-advanced-page>
18 </template> 18 </template>
19 <template is="dom-if" if="[[showAboutPage_]]">
20 <!-- TODO(dpapad): Replace this with <settings-about-page>
21 implementation -->
22 <div>$i18n{aboutPageTitle}</div>
23 </template>
19 </div> 24 </div>
20 </template> 25 </template>
21 <script src="settings_main.js"></script> 26 <script src="settings_main.js"></script>
22 </dom-module> 27 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698