chrome/browser/resources/settings/settings_main/settings_main.html - Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 1a1cabc869caeb8b9fca43cbaea5cccd7b0be3cd..9a5e61204feda1d760317df7db89a336bd0358d2 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -7,7 +7,7 @@

- <template is="dom-if" if="[[!showAdvancedPage_]]">

+ <template is="dom-if" if="[[showBasicPage_]]">

<settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">

</settings-basic-page>

</template>

@@ -16,6 +16,11 @@

current-route="{{currentRoute}}">

</settings-advanced-page>

</template>

+ <template is="dom-if" if="[[showAboutPage_]]">

+ <!-- TODO(dpapad): Replace this with <settings-about-page>

+ implementation -->

+ <div>$i18n{aboutPageTitle}</div>

+ </template>

</div>

</template>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »