third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use DCHECK, revert RuntimeEnabledFeatures.in. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ExceptionState.h ('K') | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

index 27dd511c9674261e29fe950bb769a4ed36fa4615..e975f9f6bb19dcd56d698ee72658d6ee1b635a86 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp

@@ -55,7 +55,7 @@ v8::MaybeLocal<v8::Object> V8ObjectConstructor::newInstanceInDocument(v8::Isolat

void V8ObjectConstructor::isValidConstructorMode(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (ConstructorMode::current(info.GetIsolate()) == ConstructorMode::CreateNewObject) {

- V8ThrowException::throwTypeError(info.GetIsolate(), "Illegal constructor");

+ V8ThrowException::throwIllegalConstructorTypeError(info.GetIsolate());

return;

}

v8SetReturnValue(info, info.This());