third_party/WebKit/Source/bindings/core/v8/ExceptionState.h - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use DCHECK, revert RuntimeEnabledFeatures.in. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/v0-v1-interop.html ('k') | third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

index 1f0ab6ebdb48674e6f1ff9beba316811e4f04937..d09449a838c84cb7344ed9f440388ddd234bbe1f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

@@ -84,6 +84,7 @@ public:

virtual void throwDOMException(const ExceptionCode&, const String& message);

virtual void throwTypeError(const String& message);

virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String());

+ virtual void throwSyntaxError(const String& message);

virtual void throwRangeError(const String& message);

bool hadException() const { return !m_exception.isEmpty() || m_code; }

@@ -151,6 +152,7 @@ public:

void throwDOMException(const ExceptionCode&, const String& message) override;

void throwTypeError(const String& message = String()) override;

void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;

+ void throwSyntaxError(const String& message = String()) override;

Yuki 2016/05/11 01:59:02 https://engdoc.corp.google.com/eng/doc/devguide/cp

Yuki 2016/05/11 09:29:53 ping?

void throwRangeError(const String& message) override;

};

@@ -162,6 +164,7 @@ public:

void throwDOMException(const ExceptionCode&, const String& message) override;

void throwTypeError(const String& message = String()) override;

void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) override;

+ void throwSyntaxError(const String& message = String()) override;

Yuki 2016/05/11 01:59:02 Ditto.

void throwRangeError(const String& message) override;

};