third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use DCHECK, revert RuntimeEnabledFeatures.in. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ExceptionState.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

index 2eaaa25d3cac5c81acee15188612f80af3a10f7b..adf91fbbeb2e7f34d9186178391aa317dab20415 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

@@ -54,6 +54,7 @@ public:

static v8::Local<v8::Value> throwSyntaxError(v8::Isolate*, const String&);

static v8::Local<v8::Value> createReferenceError(v8::Isolate*, const String&);

static v8::Local<v8::Value> throwReferenceError(v8::Isolate*, const String&);

+ static v8::Local<v8::Value> throwIllegalConstructorTypeError(v8::Isolate*);

haraken 2016/05/10 09:04:21 I'd prefer not adding this helper method since "Il

};

} // namespace blink