Enable subframe FrameNavigationEntries by default.

Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.

Committed: https://crrev.com/810a396cc50315037a51e55342da6c04d1c9b260
Cr-Commit-Position: refs/heads/master@{#401969}

[Charlie Reis, 2016-06-24 17:03:42]

creis@chromium.org changed reviewers:
+ boliu@chromium.org

[Charlie Reis, 2016-06-24 17:03:42]

Bo, can you review LoadDataWithBaseUrlTest.java?  The CL isn't quite ready to
land until I fix two other tests, but this is how I hope to update the Android
test when switching to the new navigation logic.

[boliu, 2016-06-24 17:35:24]

lgtm

[Charlie Reis, 2016-06-24 20:01:48]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 20:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-06-24 20:13:14]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2016-06-24 20:13:15]

Nick, can you review site_isolation_policy.cc?  

As discussed, I'll plan to get pending delete FTNs working in M54, and we'll
just lose at most 1 second of subframe PageState after cross-process navigations
for the time being (per https://crbug.com/609963).

[ncarter (slow), 2016-06-24 20:15:12]

LGTM

Please update the CL description to make it clear to sheriffs that this is a
fairly huge change to how navigation history works.

[Charlie Reis, 2016-06-24 20:22:51]

Description was changed from

==========
Enable subframe FrameNavigationEntries by default.

This removes the need for HistoryController, relying on the browser
process to handle all session history navigations per-frame inside
NavigationController.

BUG=236848
TEST=Existing tests pass.
==========

to

==========
Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.
==========

[Charlie Reis, 2016-06-24 20:23:08]

On 2016/06/24 20:15:12, ncarter wrote:
> LGTM
> 
> Please update the CL description to make it clear to sheriffs that this is a
> fairly huge change to how navigation history works.

Good idea-- done.

[Charlie Reis, 2016-06-24 20:38:08]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-06-24 20:38:15]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2016-06-24 20:38:15]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/1952533003/#ps60001
(title: "Add dependent patch sets")

[commit-bot: I haz the power, 2016-06-24 20:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:08:00]

Description was changed from

==========
Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.
==========

to

==========
Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.
==========

[commit-bot: I haz the power, 2016-06-24 21:08:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-24 21:10:52]

Description was changed from

==========
Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.
==========

to

==========
Enable subframe FrameNavigationEntries by default.

This is a major change to the navigation logic in Chrome, making
the browser process responsible for selecting subframes to
navigate.  Each NavigationEntry now has a tree of
FrameNavigationEntries representing each frame in the page, and
these frame entries track per-frame PageState.

HistoryController in content/renderer is no longer used, since
equivalent code in NavigationController in content/browser now
determines which frames to navigate.

This CL is designed to be easy to revert if regressions are
found, though the new path has been in use on 50% of Canary and
Dev channels for a while.

BUG=236848
TEST=Existing tests pass.

Committed: https://crrev.com/810a396cc50315037a51e55342da6c04d1c9b260
Cr-Commit-Position: refs/heads/master@{#401969}
==========

[commit-bot: I haz the power, 2016-06-24 21:10:53]

Patchset 4 (id:??) landed as
https://crrev.com/810a396cc50315037a51e55342da6c04d1c9b260
Cr-Commit-Position: refs/heads/master@{#401969}

[Charlie Reis, 2016-06-24 21:49:56]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2092283002/ by creis@chromium.org.

The reason for reverting is: Caused several layout tests to fail:
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac...

  fast/history/same-document-iframes-changing-fragment.html [ Failure ]
  fast/history/same-document-iframes-changing-pushstate.html [ Failure ]
  fast/loader/form-state-restore-with-frames.html [ Failure ]
  http/tests/misc/resource-timing-iframe-restored-from-history.html [ Failure ]
  http/tests/navigation/back-to-dynamic-iframe.html [ Failure ]
  http/tests/navigation/back-to-redirect-with-frame.php [ Failure ]
  http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Failure
].