Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2095833004: Disable test for rare in-page navigation kill in new navigation logic. (Closed)

Created:
4 years, 6 months ago by Charlie Reis
Modified:
4 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@workaround-for-subframe-restore-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable test for rare in-page navigation kill in new navigation logic. This case is almost never hit in practice, so it should be safe to switch to the new navigation path before fixing it. BUG=618100 TEST=No product behavior change. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/128faaf6f959fe4ab60578d3c6db8480fc932d49 Cr-Commit-Position: refs/heads/master@{#401951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M testing/buildbot/filters/isolate-extensions.content_browsertests.filter View 1 chunk +3 lines, -2 lines 0 comments Download
M testing/buildbot/filters/site-per-process.content_browsertests.filter View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Charlie Reis
Nasko, can you review? I think it's probably safe to enable the new navigation path ...
4 years, 6 months ago (2016-06-24 18:49:23 UTC) #3
Charlie Reis
[+site-isolation-reviews]
4 years, 6 months ago (2016-06-24 18:49:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095833004/1
4 years, 6 months ago (2016-06-24 19:00:16 UTC) #6
nasko
LGTM
4 years, 6 months ago (2016-06-24 20:08:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095833004/1
4 years, 6 months ago (2016-06-24 20:11:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 20:15:20 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 20:16:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/128faaf6f959fe4ab60578d3c6db8480fc932d49
Cr-Commit-Position: refs/heads/master@{#401951}

Powered by Google App Engine
This is Rietveld 408576698