Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1951813002: Revert of Postpone deletion of (Password)AutofillAgent (Closed)

Created:
3 years ago by vabr (Chromium)
Modified:
3 years ago
Reviewers:
Mathieu, dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Postpone deletion of (Password)AutofillAgent (patchset #1 id:1 of https://codereview.chromium.org/1943873002/ ) Reason for revert: This fix is not complete, I need to also handle disabling the LegacyAutofillAgent. Because the final fix is going to be merged, I prefer to have the complete solution in one CL. Therefore I am reverting this partial fix, and will reintroduce it in a new CL. Sorry for the noise. BUG=609010, 609007, 608100, 608101 Original issue's description: > Postpone deletion of (Password)AutofillAgent > > Currently, the two agent classes delete themselves immediately on destruction > of the RenderFrame they are observing. This CL postpones the deletion to a > separately posted task, to avoid the situation when the agent is deleted while > still having methods in progress lower on the stack. > > BUG=608100 > > Committed: https://crrev.com/a8755e432460c9412291c0ae4dd887babb3fa506 > Cr-Commit-Position: refs/heads/master@{#391236} TBR=mathp@chromium.org,dvadym@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608100 Committed: https://crrev.com/50bf9075cac0e5d69f5adfc0763968d5afa1734b Cr-Commit-Position: refs/heads/master@{#391465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vabr (Chromium)
Created Revert of Postpone deletion of (Password)AutofillAgent
3 years ago (2016-05-04 09:13:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951813002/1
3 years ago (2016-05-04 09:13:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years ago (2016-05-04 09:14:02 UTC) #4
commit-bot: I haz the power
3 years ago (2016-05-04 09:15:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50bf9075cac0e5d69f5adfc0763968d5afa1734b
Cr-Commit-Position: refs/heads/master@{#391465}

Powered by Google App Engine
This is Rietveld 408576698