components/autofill/content/renderer/autofill_agent.cc - Issue 1951813002: Revert of Postpone deletion of (Password)AutofillAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 1951813002: Revert of Postpone deletion of (Password)AutofillAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.cc

diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc

index 788e01b767f5e90a137f7a131b8ac468beeb5011..e233d106484d074fd3e691c6aa492bbbd637b3ca 100644

--- a/components/autofill/content/renderer/autofill_agent.cc

+++ b/components/autofill/content/renderer/autofill_agent.cc

@@ -312,14 +312,6 @@

element_ = *element;

}

-void AutofillAgent::OnDestruct() {

- // As described in http://crbug.com/608100, there might be an AutofillAgent

- // method in-progress lower on the stack. Destroying |this| would cause

- // use-after-free once the lower stack frame becomes active. Instead, a task

- // needs to be posted to delete this.

- base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);

void AutofillAgent::FocusChangeComplete() {

WebDocument doc = render_frame()->GetWebFrame()->document();

WebElement focused_element;