Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(78)

Issue 1943873002: Postpone deletion of (Password)AutofillAgent (Closed)

Created:
2 years, 10 months ago by vabr (Chromium)
Modified:
2 years, 10 months ago
Reviewers:
*Mathieu, dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Postpone deletion of (Password)AutofillAgent Currently, the two agent classes delete themselves immediately on destruction of the RenderFrame they are observing. This CL postpones the deletion to a separately posted task, to avoid the situation when the agent is deleted while still having methods in progress lower on the stack. BUG=608100 Committed: https://crrev.com/a8755e432460c9412291c0ae4dd887babb3fa506 Cr-Commit-Position: refs/heads/master@{#391236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943873002/1
2 years, 10 months ago (2016-05-03 13:38:07 UTC) #2
vabr (Chromium)
@mathp, could you please review? @dvadym, this is implementing your suggestion. Please let me know ...
2 years, 10 months ago (2016-05-03 14:43:20 UTC) #6
vabr (Chromium)
I should add that I was able to reproduce the use-after-free on the ASAN build ...
2 years, 10 months ago (2016-05-03 14:44:00 UTC) #7
Mathieu
Seems reasonable, lgtm
2 years, 10 months ago (2016-05-03 14:49:11 UTC) #8
dvadym
LGTM
2 years, 10 months ago (2016-05-03 14:52:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943873002/1
2 years, 10 months ago (2016-05-03 15:00:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 10 months ago (2016-05-03 15:04:22 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8755e432460c9412291c0ae4dd887babb3fa506 Cr-Commit-Position: refs/heads/master@{#391236}
2 years, 10 months ago (2016-05-03 15:05:42 UTC) #14
vabr (Chromium)
2 years, 10 months ago (2016-05-04 09:13:22 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1951813002/ by vabr@chromium.org.

The reason for reverting is: This fix is not complete, I need to also handle
disabling the LegacyAutofillAgent.

Because the final fix is going to be merged, I prefer to have the complete
solution in one CL. Therefore I am reverting this partial fix, and will
reintroduce it in a new CL. Sorry for the noise.

BUG=609010, 609007, 608100, 608101.

Powered by Google App Engine
This is Rietveld 408576698