[oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Source/core/html/HTMLFormControlElementWithState.cpp

Index: Source/core/html/HTMLFormControlElementWithState.cpp
diff --git a/Source/core/html/HTMLFormControlElementWithState.cpp b/Source/core/html/HTMLFormControlElementWithState.cpp
index 8c57b34dac7db2384d7cd128cdb3f2235ff0166a..1513ce3a923721bb7914c30405b72bd245423480 100644
--- a/Source/core/html/HTMLFormControlElementWithState.cpp
+++ b/Source/core/html/HTMLFormControlElementWithState.cpp
@@ -37,7 +37,7 @@ namespace WebCore {
 HTMLFormControlElementWithState::HTMLFormControlElementWithState(const QualifiedName& tagName, Document* doc, HTMLFormElement* f)
     : HTMLFormControlElement(tagName, doc, f)
 {
-    document()->formController()->registerFormElementWithState(this);
+    document()->formController()->registerFormElementWithState(Handle<HTMLFormControlElementWithState>(this));
 }
 
 HTMLFormControlElementWithState::~HTMLFormControlElementWithState()
@@ -47,8 +47,8 @@ HTMLFormControlElementWithState::~HTMLFormControlElementWithState()
 void HTMLFormControlElementWithState::didMoveToNewDocument(Document* oldDocument)
 {
     if (oldDocument)
-        oldDocument->formController()->unregisterFormElementWithState(this);
-    document()->formController()->registerFormElementWithState(this);
+        oldDocument->formController()->unregisterFormElementWithState(Handle<HTMLFormControlElementWithState>(this));

[Vyacheslav Egorov (Google), 2013/07/18 16:50:08]

I wonder if every class should have two methods like this declared:

class T {
private:
  Result<T> self() { return adoptRawResult(this); }
  Result<const T> self() const { return adoptRawResult(this); }
}

[haraken, 2013/07/19 02:57:09]

Agreed. Let me do that in a separate CL.

+    document()->formController()->registerFormElementWithState(Handle<HTMLFormControlElementWithState>(this));
     HTMLFormControlElement::didMoveToNewDocument(oldDocument);
 }
 
@@ -83,7 +83,7 @@ FormControlState HTMLFormControlElementWithState::saveFormControlState() const
 void HTMLFormControlElementWithState::finishParsingChildren()
 {
     HTMLFormControlElement::finishParsingChildren();
-    document()->formController()->restoreControlStateFor(*this);
+    document()->formController()->restoreControlStateFor(Handle<HTMLFormControlElementWithState>(this));
 }
 
 bool HTMLFormControlElementWithState::isFormControlElementWithState() const
@@ -91,4 +91,9 @@ bool HTMLFormControlElementWithState::isFormControlElementWithState() const
     return true;
 }
 
+void HTMLFormControlElementWithState::acceptHeapVisitor(Visitor* visitor) const
+{
+    HTMLFormControlElement::acceptHeapVisitor(visitor);
+}
+
 } // namespace Webcore