Source/core/html/HTMLFormElement.h - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.h

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFormControlElementWithState.cpp ('K') | « Source/core/html/HTMLFormControlElementWithState.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | Source/core/html/HTMLFormElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.h

diff --git a/Source/core/html/HTMLFormElement.h b/Source/core/html/HTMLFormElement.h

index 08c89696b8bce4522aec13c749bf96402844c0af..6dd669f3baf5a329ec77656cba46dd87be96e760 100644

--- a/Source/core/html/HTMLFormElement.h

+++ b/Source/core/html/HTMLFormElement.h

@@ -94,7 +94,7 @@ public:

bool wasUserSubmitted() const;

- HTMLFormControlElement* defaultButton() const;

+ Result<HTMLFormControlElement> defaultButton() const;

bool checkValidity();

@@ -111,8 +111,8 @@ public:

DEFINE_ATTRIBUTE_EVENT_LISTENER(autocomplete);

DEFINE_ATTRIBUTE_EVENT_LISTENER(autocompleteerror);

- HTMLFormControlElement* elementForAlias(const AtomicString&);

- void addElementAlias(HTMLFormControlElement*, const AtomicString& alias);

+ Result<HTMLFormControlElement> elementForAlias(const AtomicString&);

+ void addElementAlias(Handle<HTMLFormControlElement>, const AtomicString& alias);

CheckedRadioButtons& checkedRadioButtons() { return m_checkedRadioButtons; }

@@ -151,7 +151,7 @@ private:

// are any invalid controls in this form.

bool checkInvalidControlsAndCollectUnhandled(Vector<RefPtr<FormAssociatedElement> >&);

- typedef HashMap<RefPtr<AtomicStringImpl>, RefPtr<HTMLFormControlElement> > AliasMap;

+ typedef HashMap<RefPtr<AtomicStringImpl>, Persistent<HTMLFormControlElement> > AliasMap;

FormSubmission::Attributes m_attributes;

OwnPtr<AliasMap> m_elementAliases;