[oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Source/core/html/HTMLFormControlElementWithState.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 19 matching lines @@
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/Frame.h"
 #include "core/page/Page.h"
 
 namespace WebCore {
 
 HTMLFormControlElementWithState::HTMLFormControlElementWithState(const QualifiedName& tagName, Document* doc, HTMLFormElement* f)
     : HTMLFormControlElement(tagName, doc, f)
 {
-    document()->formController()->registerFormElementWithState(this);
+    document()->formController()->registerFormElementWithState(Handle<HTMLFormControlElementWithState>(this));
 }
 
 HTMLFormControlElementWithState::~HTMLFormControlElementWithState()
 {
 }
 
 void HTMLFormControlElementWithState::didMoveToNewDocument(Document* oldDocument)
 {
     if (oldDocument)
-        oldDocument->formController()->unregisterFormElementWithState(this);
-    document()->formController()->registerFormElementWithState(this);
+        oldDocument->formController()->unregisterFormElementWithState(Handle<HTMLFormControlElementWithState>(this));

[Vyacheslav Egorov (Google), 2013/07/18 16:50:08]

I wonder if every class should have two methods like this declared:

class T {
private:
  Result<T> self() { return adoptRawResult(this); }
  Result<const T> self() const { return adoptRawResult(this); }
}

[haraken, 2013/07/19 02:57:09]

Agreed. Let me do that in a separate CL.

+    document()->formController()->registerFormElementWithState(Handle<HTMLFormControlElementWithState>(this));
     HTMLFormControlElement::didMoveToNewDocument(oldDocument);
 }
 
 bool HTMLFormControlElementWithState::shouldAutocomplete() const
 {
     if (!form())
         return true;
     return form()->shouldAutocomplete();
 }
 
@@ skipping 14 matching lines @@
 }
 
 FormControlState HTMLFormControlElementWithState::saveFormControlState() const
 {
     return FormControlState();
 }
 
 void HTMLFormControlElementWithState::finishParsingChildren()
 {
     HTMLFormControlElement::finishParsingChildren();
-    document()->formController()->restoreControlStateFor(*this);
+    document()->formController()->restoreControlStateFor(Handle<HTMLFormControlElementWithState>(this));
 }
 
 bool HTMLFormControlElementWithState::isFormControlElementWithState() const
 {
     return true;
 }
 
+void HTMLFormControlElementWithState::acceptHeapVisitor(Visitor* visitor) const
+{
+    HTMLFormControlElement::acceptHeapVisitor(visitor);
+}
+
 } // namespace Webcore