Source/WebKit/chromium/src/ContextMenuClientImpl.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebKit/chromium/src/ChromeClientImpl.cpp ('k') | Source/WebKit/chromium/src/EditorClientImpl.cpp » ('j') | Source/WebKit/chromium/src/WebFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

diff --git a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

index d79729885fa35878eb49bdbb71c4b8d8b02fe8c9..33aa7d26ac7b4e28db3f671022ef1c70ce04a409 100644

--- a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

+++ b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

@@ -338,7 +338,7 @@ PassOwnPtr<WebCore::ContextMenu> ContextMenuClientImpl::customizeMenu(PassOwnPtr

}

HTMLFormElement* form = selectedFrame->selection()->currentForm();

if (form && r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag)) {

- HTMLInputElement* selectedElement = static_cast<HTMLInputElement*>(r.innerNonSharedNode());

+ Handle<HTMLInputElement> selectedElement(static_cast<HTMLInputElement*>(r.innerNonSharedNode()));

Vyacheslav Egorov (Google) 2013/07/18 16:50:08 I wonder if we should be using Handle<HTMLInput

haraken 2013/07/19 02:57:09 Done. I fixed all places.

if (selectedElement) {

WebSearchableFormData ws = WebSearchableFormData(WebFormElement(form), WebInputElement(selectedElement));

if (ws.url().isValid())