Source/WebKit/chromium/src/ChromeClientImpl.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/ChromeClientImpl.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebKit/chromium/src/ChromeClientImpl.h ('k') | Source/WebKit/chromium/src/ContextMenuClientImpl.cpp » ('j') | Source/WebKit/chromium/src/ContextMenuClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/ChromeClientImpl.cpp

diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp b/Source/WebKit/chromium/src/ChromeClientImpl.cpp

index a0b2b9c84dad493ab1fb12b1a36a41acb3cb0ccc..299062df6214b8f2fd09c6979c94e557dc544ea1 100644

--- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp

+++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp

@@ -1077,7 +1077,7 @@ void ChromeClientImpl::resetPagePopupDriver()

}

#endif

-bool ChromeClientImpl::willAddTextFieldDecorationsTo(HTMLInputElement* input)

+bool ChromeClientImpl::willAddTextFieldDecorationsTo(Handle<HTMLInputElement> input)

{

ASSERT(input);

const Vector<OwnPtr<TextFieldDecorator> >& decorators = m_webView->textFieldDecorators();

@@ -1088,7 +1088,7 @@ bool ChromeClientImpl::willAddTextFieldDecorationsTo(HTMLInputElement* input)

return false;

}

-void ChromeClientImpl::addTextFieldDecorationsTo(HTMLInputElement* input)

+void ChromeClientImpl::addTextFieldDecorationsTo(Handle<HTMLInputElement> input)

{

ASSERT(willAddTextFieldDecorationsTo(input));

const Vector<OwnPtr<TextFieldDecorator> >& decorators = m_webView->textFieldDecorators();