Source/WebKit/chromium/src/EditorClientImpl.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/EditorClientImpl.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/src/ContextMenuClientImpl.cpp ('K') | « Source/WebKit/chromium/src/ContextMenuClientImpl.cpp ('k') | Source/WebKit/chromium/src/TextFieldDecoratorImpl.h » ('j') | Source/WebKit/chromium/src/WebFormControlElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/EditorClientImpl.cpp

diff --git a/Source/WebKit/chromium/src/EditorClientImpl.cpp b/Source/WebKit/chromium/src/EditorClientImpl.cpp

index 4c6dbf05761efb9b42ce711d598a02f949928ad5..760b4e65fc1632a819f59754b02ba32aea349c57 100644

--- a/Source/WebKit/chromium/src/EditorClientImpl.cpp

+++ b/Source/WebKit/chromium/src/EditorClientImpl.cpp

@@ -656,7 +656,7 @@ void EditorClientImpl::textFieldDidBeginEditing(Element* element)

void EditorClientImpl::textFieldDidEndEditing(Element* element)

{

- HTMLInputElement* inputElement = element->toInputElement();

+ Handle<HTMLInputElement> inputElement = element->toInputElement();

if (m_webView->autofillClient() && inputElement)

m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(inputElement));

@@ -670,7 +670,7 @@ void EditorClientImpl::textFieldDidEndEditing(Element* element)

void EditorClientImpl::textDidChangeInTextField(Element* element)

{

ASSERT(element->hasLocalName(HTMLNames::inputTag));

- HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(element);

+ Handle<HTMLInputElement> inputElement(static_cast<HTMLInputElement*>(element));

if (m_webView->autofillClient())

m_webView->autofillClient()->textFieldDidChange(WebInputElement(inputElement));

}

@@ -678,7 +678,7 @@ void EditorClientImpl::textDidChangeInTextField(Element* element)

bool EditorClientImpl::doTextFieldCommandFromEvent(Element* element,

KeyboardEvent* event)

{

- HTMLInputElement* inputElement = element->toInputElement();

+ Handle<HTMLInputElement> inputElement = element->toInputElement();

if (m_webView->autofillClient() && inputElement) {

m_webView->autofillClient()->textFieldDidReceiveKeyDown(WebInputElement(inputElement),

WebKeyboardEventBuilder(*event));