Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1950763002: Remove abstractions around GLuint and GL constants. (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, dshwang, eric.carlson_apple.com, kinuko+watch, rwlbuis, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, jam, Justin Novosad, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, blink-reviews, mlamouri+watch-content_chromium.org, jbroman, feature-media-reviews_chromium.org, krit, haraken, piman+watch_chromium.org, Stephen Chennney, mlamouri+watch-blink_chromium.org, f(malita), mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, dcheng, Ken Russell (switch to Gerrit), piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove abstractions around GLuint and GL constants. Just include gl2.h and use the GL things. Removes the Platform3DObject type alias and some local constant re-declarations. Also some bonus removals of WebGraphicsContext3D references. R=kbr@chromium.org, piman BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7ee4f26a04bb41b0b260e8ad8e0d7a14a76c43ce Cr-Commit-Position: refs/heads/master@{#391642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -48 lines) Patch
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 3 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLShaderPrecisionFormat.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSharedPlatform3DObject.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSharedPlatform3DObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes3D.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
danakj
4 years, 7 months ago (2016-05-03 23:44:55 UTC) #5
danakj
piman: content and gpu, and DEPS. kbr: the rest
4 years, 7 months ago (2016-05-03 23:45:34 UTC) #6
piman
lgtm
4 years, 7 months ago (2016-05-03 23:47:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950763002/1
4 years, 7 months ago (2016-05-03 23:49:02 UTC) #8
Ken Russell (switch to Gerrit)
Excellent. LGTM
4 years, 7 months ago (2016-05-03 23:58:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950763002/1
4 years, 7 months ago (2016-05-03 23:59:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/215921)
4 years, 7 months ago (2016-05-04 05:51:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950763002/1
4 years, 7 months ago (2016-05-04 19:46:05 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 21:15:26 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 21:16:31 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ee4f26a04bb41b0b260e8ad8e0d7a14a76c43ce
Cr-Commit-Position: refs/heads/master@{#391642}

Powered by Google App Engine
This is Rietveld 408576698