third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 1950763002: Remove abstractions around GLuint and GL constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 1950763002: Remove abstractions around GLuint and GL constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index 0f60ffe4fc753417867cc00a8d4367a876e73fe3..860112e198ebbc02789f0515fbe5114063328876 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -92,7 +92,7 @@ void WebGLRenderbufferAttachment::onDetached(gpu::gles2::GLES2Interface* gl)

void WebGLRenderbufferAttachment::attach(gpu::gles2::GLES2Interface* gl, GLenum target, GLenum attachment)

{

- Platform3DObject object = objectOrZero(m_renderbuffer.get());

+ GLuint object = objectOrZero(m_renderbuffer.get());

gl->FramebufferRenderbuffer(target, attachment, GL_RENDERBUFFER, object);

}

@@ -165,7 +165,7 @@ void WebGLTextureAttachment::onDetached(gpu::gles2::GLES2Interface* gl)

void WebGLTextureAttachment::attach(gpu::gles2::GLES2Interface* gl, GLenum target, GLenum attachment)

{

- Platform3DObject object = objectOrZero(m_texture.get());

+ GLuint object = objectOrZero(m_texture.get());

if (m_target == GL_TEXTURE_3D || m_target == GL_TEXTURE_2D_ARRAY) {

gl->FramebufferTextureLayer(target, attachment, object, m_level, m_layer);

} else {