Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
diff --git a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
index 06e65c066f443b795aa844588804f375c755b69a..9ea98117be22d9f60ead394239f2b520c1ec3105 100644
--- a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
+++ b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
@@ -4,12 +4,19 @@
<script src="../../resources/js-test.js"></script>
<script>
- var input = document.getElementById('text');
- input.focus();
- textInputController.setMarkedText("hello", 0, 5);
- var markedRangeResultGC = internals.observeGC(textInputController.markedRange());
- var selectedRangeResultGC = internals.observeGC(textInputController.selectedRange());
- var firstRectForCharacterRangeGC = internals.observeGC(textInputController.firstRectForCharacterRange(0, 0));
+ var markedRangeResultGC;
+ var selectedRangeResultGC;
+ var firstRectForCharacterRangeGC;
+ var input;
+ function initializeVariables() {
+ input = document.getElementById('text');
+ input.focus();
+ textInputController.setMarkedText("hello", 0, 5);
+ markedRangeResultGC = internals.observeGC(textInputController.markedRange());
+ selectedRangeResultGC = internals.observeGC(textInputController.selectedRange());
+ firstRectForCharacterRangeGC = internals.observeGC(textInputController.firstRectForCharacterRange(0, 0));
rmcilroy 2016/05/05 13:50:46 What actually lives in a temporary register and ne
+ }
+ initializeVariables();
gc();
shouldBeTrue('markedRangeResultGC.wasCollected');
shouldBeTrue('selectedRangeResultGC.wasCollected');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698