third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html ('K') | « third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html b/third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

index 4cb6819f14bb9594483aaa5efd7575a9f78e152a..1ee5ef6d432f3bed7c5364a1bf7676426c55cdd8 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html

@@ -6,10 +6,15 @@ if (window.testRunner) {

testRunner.waitUntilDone();

testRunner.dumpAsText();

}

-var observer = new MutationObserver(function() {console.log('Should not appear')});

-var div = document.createElement('div');

-observer.observe(div, {attributes: true});

-div.id = 'foo';

+var observer, div;

+function initializeObserver() {

+ observer = new MutationObserver(function() {console.log('Should not appear')});

+ div = document.createElement('div');

+ observer.observe(div, {attributes: true});

+ div.id = 'foo';

+initializeObserver();

div = null;

observer = null;

gc();