third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <input id='text' type='text'></input>	3 <input id='text' type='text'></input>

4	4

5 <script src="../../resources/js-test.js"></script>	5 <script src="../../resources/js-test.js"></script>

6 <script>	6 <script>

7 var input = document.getElementById('text');	7 var markedRangeResultGC;

8 input.focus();	8 var selectedRangeResultGC;

9 textInputController.setMarkedText("hello", 0, 5);	9 var firstRectForCharacterRangeGC;

10 var markedRangeResultGC = internals.observeGC(textInputController.marked Range());	10 var input;

11 var selectedRangeResultGC = internals.observeGC(textInputController.sele ctedRange());	11 function initializeVariables() {

12 var firstRectForCharacterRangeGC = internals.observeGC(textInputControll er.firstRectForCharacterRange(0, 0));	12 input = document.getElementById('text');

	13 input.focus();

	14 textInputController.setMarkedText("hello", 0, 5);

	15 markedRangeResultGC = internals.observeGC(textInputController.markedRa nge());

	16 selectedRangeResultGC = internals.observeGC(textInputController.select edRange());

	17 firstRectForCharacterRangeGC = internals.observeGC(textInputController .firstRectForCharacterRange(0, 0));
	rmcilroy 2016/05/05 13:50:46 What actually lives in a temporary register and ne What actually lives in a temporary register and needs to be cleared here before the GC for it to work? Presumably just the arguments to the observeGC calls. Could we do something more clever by changing the observeGC API to ensure that the arguments are never maintained in dead registers?
	18 }

	19 initializeVariables();

13 gc();	20 gc();

14 shouldBeTrue('markedRangeResultGC.wasCollected');	21 shouldBeTrue('markedRangeResultGC.wasCollected');

15 shouldBeTrue('selectedRangeResultGC.wasCollected');	22 shouldBeTrue('selectedRangeResultGC.wasCollected');

16 shouldBeTrue('firstRectForCharacterRangeGC.wasCollected');	23 shouldBeTrue('firstRectForCharacterRangeGC.wasCollected');

17 </script>	24 </script>

18 </body>	25 </body>

19 </html>	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html » ('j') | no next file with comments »