Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950573002: Nukes WmWindow::SetName() (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Nukes WmWindow::SetName() Instead it should be passed through InitParams. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf Cr-Commit-Position: refs/heads/master@{#391355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M ash/wm/aura/wm_window_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/common/workspace/phantom_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 7 months ago (2016-05-03 19:32:27 UTC) #1
sky
4 years, 7 months ago (2016-05-03 19:32:28 UTC) #2
James Cook
lgtm
4 years, 7 months ago (2016-05-03 20:50:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950573002/1
4 years, 7 months ago (2016-05-03 21:03:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 21:12:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:14:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf
Cr-Commit-Position: refs/heads/master@{#391355}

Powered by Google App Engine
This is Rietveld 408576698