Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: ash/wm/common/wm_window.h

Issue 1950573002: Nukes WmWindow::SetName() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/wm/aura/wm_window_aura.cc ('k') | ash/wm/common/workspace/phantom_window_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_WM_COMMON_WM_WINDOW_H_ 5 #ifndef ASH_WM_COMMON_WM_WINDOW_H_
6 #define ASH_WM_COMMON_WM_WINDOW_H_ 6 #define ASH_WM_COMMON_WM_WINDOW_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 WmWindow* GetRootWindow() { 54 WmWindow* GetRootWindow() {
55 return const_cast<WmWindow*>( 55 return const_cast<WmWindow*>(
56 const_cast<const WmWindow*>(this)->GetRootWindow()); 56 const_cast<const WmWindow*>(this)->GetRootWindow());
57 } 57 }
58 virtual const WmWindow* GetRootWindow() const = 0; 58 virtual const WmWindow* GetRootWindow() const = 0;
59 virtual WmRootWindowController* GetRootWindowController() = 0; 59 virtual WmRootWindowController* GetRootWindowController() = 0;
60 60
61 // TODO(sky): fix constness. 61 // TODO(sky): fix constness.
62 virtual WmGlobals* GetGlobals() const = 0; 62 virtual WmGlobals* GetGlobals() const = 0;
63 63
64 // Used for debugging.
65 virtual void SetName(const std::string& name) = 0;
66
67 // See wm_shell_window_ids.h for list of known ids. 64 // See wm_shell_window_ids.h for list of known ids.
68 virtual void SetShellWindowId(int id) = 0; 65 virtual void SetShellWindowId(int id) = 0;
69 virtual int GetShellWindowId() const = 0; 66 virtual int GetShellWindowId() const = 0;
70 virtual WmWindow* GetChildByShellWindowId(int id) = 0; 67 virtual WmWindow* GetChildByShellWindowId(int id) = 0;
71 68
72 virtual ui::wm::WindowType GetType() const = 0; 69 virtual ui::wm::WindowType GetType() const = 0;
73 70
74 // TODO(sky): seems like this shouldn't be exposed. 71 // TODO(sky): seems like this shouldn't be exposed.
75 virtual ui::Layer* GetLayer() = 0; 72 virtual ui::Layer* GetLayer() = 0;
76 73
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 virtual void RemoveObserver(WmWindowObserver* observer) = 0; 202 virtual void RemoveObserver(WmWindowObserver* observer) = 0;
206 203
207 protected: 204 protected:
208 virtual ~WmWindow() {} 205 virtual ~WmWindow() {}
209 }; 206 };
210 207
211 } // namespace wm 208 } // namespace wm
212 } // namespace ash 209 } // namespace ash
213 210
214 #endif // ASH_WM_COMMON_WM_WINDOW_H_ 211 #endif // ASH_WM_COMMON_WM_WINDOW_H_
OLDNEW
« no previous file with comments | « ash/wm/aura/wm_window_aura.cc ('k') | ash/wm/common/workspace/phantom_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698