Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: ash/wm/common/workspace/phantom_window_controller.cc

Issue 1950573002: Nukes WmWindow::SetName() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/common/wm_window.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/common/workspace/phantom_window_controller.cc
diff --git a/ash/wm/common/workspace/phantom_window_controller.cc b/ash/wm/common/workspace/phantom_window_controller.cc
index e015da185c83c81307e15968ade86af426162ac7..53cdcbb55b34f84667c49f41d345473279b5a10d 100644
--- a/ash/wm/common/workspace/phantom_window_controller.cc
+++ b/ash/wm/common/workspace/phantom_window_controller.cc
@@ -112,13 +112,13 @@ std::unique_ptr<views::Widget> PhantomWindowController::CreatePhantomWidget(
// the phantom is visible.
params.keep_on_top = true;
params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+ params.name = "PhantomWindow";
root_window->GetRootWindowController()->ConfigureWidgetInitParamsForContainer(
phantom_widget.get(), kShellWindowId_ShelfContainer, &params);
phantom_widget->set_focus_on_creation(false);
phantom_widget->Init(params);
phantom_widget->SetVisibilityChangedAnimationsEnabled(false);
wm::WmWindow* phantom_widget_window = wm::WmWindow::Get(phantom_widget.get());
- phantom_widget_window->SetName("PhantomWindow");
phantom_widget_window->SetShellWindowId(kShellWindowId_PhantomWindow);
phantom_widget->SetBounds(bounds_in_screen);
// TODO(sky): I suspect this is never true, verify that.
« no previous file with comments | « ash/wm/common/wm_window.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698