Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1950523002: Remove GrLayerHoister (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrLayerHoister This relies on https://codereview.chromium.org/1944013002/ (Add legacy flag to allow Skia to remove Ganesh layer hoister) landing first so as to not break the DEPS roll. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950523002 Committed: https://skia.googlesource.com/skia/+/dda54455a20dcd89de610bdb80e4a8e9137b80a4

Patch Set 1 #

Patch Set 2 : add guard for Chrome #

Patch Set 3 : More cleanup #

Patch Set 4 : update to ToT #

Patch Set 5 : fix rebase #

Patch Set 6 : Forgot to remove some files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3037 lines) Patch
M bench/RecordingBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/nanobench.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M gm/multipicturedraw.cpp View 6 chunks +6 lines, -12 lines 0 comments Download
M gyp/core.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M include/core/SkDevice.h View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkBigPicture.h View 1 2 3 4 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkBigPicture.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
D src/core/SkLayerInfo.h View 1 chunk +0 lines, -87 lines 0 comments Download
M src/core/SkMultiPictureDraw.cpp View 1 2 3 2 chunks +1 line, -100 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 2 3 4 chunks +3 lines, -15 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 3 chunks +0 lines, -207 lines 0 comments Download
M src/core/SkRecordedDrawable.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkRecordedDrawable.cpp View 3 chunks +1 line, -11 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 5 chunks +0 lines, -6 lines 0 comments Download
D src/gpu/GrLayerAtlas.h View 1 chunk +0 lines, -157 lines 0 comments Download
D src/gpu/GrLayerAtlas.cpp View 1 chunk +0 lines, -168 lines 0 comments Download
D src/gpu/GrLayerCache.h View 1 chunk +0 lines, -432 lines 0 comments Download
D src/gpu/GrLayerCache.cpp View 1 chunk +0 lines, -557 lines 0 comments Download
D src/gpu/GrLayerHoister.h View 1 2 3 4 5 1 chunk +0 lines, -130 lines 0 comments Download
D src/gpu/GrLayerHoister.cpp View 1 2 3 4 5 1 chunk +0 lines, -402 lines 0 comments Download
D src/gpu/GrRecordReplaceDraw.h View 1 chunk +0 lines, -26 lines 0 comments Download
D src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 3 chunks +0 lines, -76 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 chunks +1 line, -205 lines 0 comments Download
D tests/RecordReplaceDrawTest.cpp View 1 2 3 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
robertphillips
4 years, 7 months ago (2016-05-03 18:31:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950523002/40001
4 years, 7 months ago (2016-05-03 18:35:07 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 18:48:22 UTC) #10
bsalomon
lgtm
4 years, 7 months ago (2016-05-03 18:55:19 UTC) #11
tomhudson
On 2016/05/03 18:55:19, bsalomon wrote: > lgtm Rob, Brian, this never landed? (Cleaning up legacy ...
4 years, 6 months ago (2016-06-25 18:15:46 UTC) #12
bsalomon
On 2016/06/25 18:15:46, tomhudson wrote: > On 2016/05/03 18:55:19, bsalomon wrote: > > lgtm > ...
4 years, 5 months ago (2016-06-27 13:11:03 UTC) #13
robertphillips
https://codereview.chromium.org/1945413003/ (Disable Ganesh layer hoister in a more revertable form) seems to have landed w/o ...
4 years, 5 months ago (2016-07-13 19:20:51 UTC) #14
bsalomon
On 2016/07/13 19:20:51, robertphillips wrote: > https://codereview.chromium.org/1945413003/ (Disable Ganesh layer hoister in a > more ...
4 years, 5 months ago (2016-07-13 19:27:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1950523002/100001
4 years, 5 months ago (2016-07-13 20:26:06 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/dda54455a20dcd89de610bdb80e4a8e9137b80a4
4 years, 5 months ago (2016-07-13 20:27:22 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:27:26 UTC) #29
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698