Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1944013002:
Add legacy flag to allow Skia to remove Ganesh layer hoister (Closed)
|
Created:
4 years, 7 months ago by robertphillips Modified:
4 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd legacy flag to allow Skia to remove Ganesh layer hoister
The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium
Committed: https://crrev.com/ecf10f23a268a9d89fa971ed7a4c5bf44b807ae8
Cr-Commit-Position: refs/heads/master@{#391573}
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Add legacy flag to allow Skia to remove Ganesh layer hoister ========== to ========== Add legacy flag to allow Skia to remove Ganesh layer hoister The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944013002/1
robertphillips@google.com changed reviewers: + bsalomon@chromium.org, fmalita@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944013002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944013002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/05/04 18:01:40, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. lgtm
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1944013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1944013002/1
Message was sent while issue was closed.
Description was changed from ========== Add legacy flag to allow Skia to remove Ganesh layer hoister The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium ========== to ========== Add legacy flag to allow Skia to remove Ganesh layer hoister The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add legacy flag to allow Skia to remove Ganesh layer hoister The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium ========== to ========== Add legacy flag to allow Skia to remove Ganesh layer hoister The Ganesh layer hoister is going away in https://codereview.chromium.org/1950523002/ (Remove GrLayerHoister). This CL stages its removal from Chromium Committed: https://crrev.com/ecf10f23a268a9d89fa971ed7a4c5bf44b807ae8 Cr-Commit-Position: refs/heads/master@{#391573} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ecf10f23a268a9d89fa971ed7a4c5bf44b807ae8 Cr-Commit-Position: refs/heads/master@{#391573} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
