Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1950233002: Fix a bug in texture validation. (Closed)

Created:
4 years, 7 months ago by Zhenyao Mo
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in texture validation. We didn't consider MAX_ARRAY_TEXTURE_LAYERS. Also, change LOG to DLOG in context group creation time. BUG=429053, 605717 TEST=gpu_unittests R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1 Cr-Commit-Position: refs/heads/master@{#391754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -75 lines) Patch
M gpu/command_buffer/service/context_group.cc View 14 chunks +79 lines, -66 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 25 chunks +40 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Zhenyao Mo
piman: PTAL
4 years, 7 months ago (2016-05-05 00:10:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950233002/1
4 years, 7 months ago (2016-05-05 00:11:14 UTC) #4
piman
lgtm
4 years, 7 months ago (2016-05-05 01:38:27 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65336)
4 years, 7 months ago (2016-05-05 02:06:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950233002/1
4 years, 7 months ago (2016-05-05 03:40:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 04:35:38 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 04:37:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1
Cr-Commit-Position: refs/heads/master@{#391754}

Powered by Google App Engine
This is Rietveld 408576698