Improve indexed gl state related GL commands.

Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) Implement indexed UNIFORM_BUFFER bindings tracking and
   restoring in context switching
4) shadow GetIntegeri_v and GetInteger64i_v
5) Improve validation for FramebufferTextureLayer().

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/48ee6d3fd938f151f1d3f84c8e54738438c86de0
Cr-Commit-Position: refs/heads/master@{#392140}

[Zhenyao Mo, 2016-05-05 00:34:18]

Description was changed from

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) shadow GetIntegeri_v and GetInteger64i_v

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
==========

to

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) shadow GetIntegeri_v and GetInteger64i_v

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-05 01:14:23]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 01:14:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303003/20001

[commit-bot: I haz the power, 2016-05-05 02:42:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 02:42:44]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-05-05 20:06:49]

Description was changed from

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) shadow GetIntegeri_v and GetInteger64i_v

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) Implement indexed UNIFORM_BUFFER bindings tracking and
   restoring in context switching
4) shadow GetIntegeri_v and GetInteger64i_v
5) Improve validation for FramebufferTextureLayer().

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-05 21:13:44]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-05-05 21:14:07]

piman: PTAL
kbr: FYI (and feel free to review)

[commit-bot: I haz the power, 2016-05-05 21:14:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303003/60001

[Zhenyao Mo, 2016-05-05 21:24:36]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 21:25:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303003/80001

[piman, 2016-05-05 21:27:40]

lgtm

https://codereview.chromium.org/1949303003/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1949303003/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4813: DCHECK(bindings.get());
nit: DCHECK(bindings)

[Zhenyao Mo, 2016-05-05 21:33:10]

https://codereview.chromium.org/1949303003/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1949303003/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4813: DCHECK(bindings.get());
On 2016/05/05 21:27:39, piman wrote:
> nit: DCHECK(bindings)

Done.

[Zhenyao Mo, 2016-05-05 21:38:02]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-05-05 21:38:02]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949303003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-05 21:38:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303003/100001

[Ken Russell (switch to Gerrit), 2016-05-05 21:42:54]

Excellent. lgtm too.

[commit-bot: I haz the power, 2016-05-06 00:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 00:08:52]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Zhenyao Mo, 2016-05-06 19:27:28]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-05-06 19:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1949303003/#ps120001
(title: "fix a DCHECK failure")

[commit-bot: I haz the power, 2016-05-06 19:27:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303003/120001

[commit-bot: I haz the power, 2016-05-06 20:33:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-06 20:35:44]

Description was changed from

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) Implement indexed UNIFORM_BUFFER bindings tracking and
   restoring in context switching
4) shadow GetIntegeri_v and GetInteger64i_v
5) Improve validation for FramebufferTextureLayer().

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Improve indexed gl state related GL commands.

1) draw* calls check for transformfeedback states.
2) add auto-generated parameter validation for unsafe commands
   (and remove them from handwritten code)
3) Implement indexed UNIFORM_BUFFER bindings tracking and
   restoring in context switching
4) shadow GetIntegeri_v and GetInteger64i_v
5) Improve validation for FramebufferTextureLayer().

BUG=604436
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/48ee6d3fd938f151f1d3f84c8e54738438c86de0
Cr-Commit-Position: refs/heads/master@{#392140}
==========

[commit-bot: I haz the power, 2016-05-06 20:35:45]

Patchset 7 (id:??) landed as
https://crrev.com/48ee6d3fd938f151f1d3f84c8e54738438c86de0
Cr-Commit-Position: refs/heads/master@{#392140}