Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager_unittest.cc

Issue 1950233002: Fix a bug in texture validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/context_group.cc ('k') | gpu/command_buffer/service/test_helper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "gpu/command_buffer/service/error_state_mock.h" 8 #include "gpu/command_buffer/service/error_state_mock.h"
9 #include "gpu/command_buffer/service/feature_info.h" 9 #include "gpu/command_buffer/service/feature_info.h"
10 #include "gpu/command_buffer/service/framebuffer_manager.h" 10 #include "gpu/command_buffer/service/framebuffer_manager.h"
11 #include "gpu/command_buffer/service/gles2_cmd_decoder_mock.h" 11 #include "gpu/command_buffer/service/gles2_cmd_decoder_mock.h"
12 #include "gpu/command_buffer/service/gpu_service_test.h" 12 #include "gpu/command_buffer/service/gpu_service_test.h"
13 #include "gpu/command_buffer/service/renderbuffer_manager.h" 13 #include "gpu/command_buffer/service/renderbuffer_manager.h"
14 #include "gpu/command_buffer/service/test_helper.h" 14 #include "gpu/command_buffer/service/test_helper.h"
15 #include "gpu/command_buffer/service/texture_manager.h" 15 #include "gpu/command_buffer/service/texture_manager.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include "ui/gl/gl_mock.h" 17 #include "ui/gl/gl_mock.h"
18 18
19 using ::testing::_; 19 using ::testing::_;
20 using ::testing::Return; 20 using ::testing::Return;
21 21
22 namespace gpu { 22 namespace gpu {
23 namespace gles2 { 23 namespace gles2 {
24 namespace { 24 namespace {
25 25
26 const GLint kMaxTextureSize = 64; 26 const GLint kMaxTextureSize = 64;
27 const GLint kMaxCubemapSize = 64; 27 const GLint kMaxCubemapSize = 64;
28 const GLint kMaxRectangleTextureSize = 64; 28 const GLint kMaxRectangleTextureSize = 64;
29 const GLint kMax3DTextureSize = 256; 29 const GLint kMax3DTextureSize = 256;
30 const GLint kMaxArrayTextureLayers = 256;
30 const GLint kMaxRenderbufferSize = 64; 31 const GLint kMaxRenderbufferSize = 64;
31 const GLint kMaxSamples = 4; 32 const GLint kMaxSamples = 4;
32 const uint32_t kMaxDrawBuffers = 16; 33 const uint32_t kMaxDrawBuffers = 16;
33 const uint32_t kMaxColorAttachments = 16; 34 const uint32_t kMaxColorAttachments = 16;
34 const bool kUseDefaultTextures = false; 35 const bool kUseDefaultTextures = false;
35 36
36 } // namespace 37 } // namespace
37 38
38 class FramebufferManagerTest : public GpuServiceTest { 39 class FramebufferManagerTest : public GpuServiceTest {
39 public: 40 public:
40 FramebufferManagerTest() 41 FramebufferManagerTest()
41 : manager_(1, 1, CONTEXT_TYPE_OPENGLES2, NULL), 42 : manager_(1, 1, CONTEXT_TYPE_OPENGLES2, NULL),
42 feature_info_(new FeatureInfo()) { 43 feature_info_(new FeatureInfo()) {
43 texture_manager_.reset(new TextureManager(NULL, 44 texture_manager_.reset(new TextureManager(NULL,
44 feature_info_.get(), 45 feature_info_.get(),
45 kMaxTextureSize, 46 kMaxTextureSize,
46 kMaxCubemapSize, 47 kMaxCubemapSize,
47 kMaxRectangleTextureSize, 48 kMaxRectangleTextureSize,
48 kMax3DTextureSize, 49 kMax3DTextureSize,
50 kMaxArrayTextureLayers,
49 kUseDefaultTextures)); 51 kUseDefaultTextures));
50 renderbuffer_manager_.reset(new RenderbufferManager(NULL, 52 renderbuffer_manager_.reset(new RenderbufferManager(NULL,
51 kMaxRenderbufferSize, 53 kMaxRenderbufferSize,
52 kMaxSamples, 54 kMaxSamples,
53 feature_info_.get())); 55 feature_info_.get()));
54 } 56 }
55 ~FramebufferManagerTest() override { 57 ~FramebufferManagerTest() override {
56 manager_.Destroy(false); 58 manager_.Destroy(false);
57 texture_manager_->Destroy(false); 59 texture_manager_->Destroy(false);
58 renderbuffer_manager_->Destroy(false); 60 renderbuffer_manager_->Destroy(false);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 kMaxColorAttachments, 121 kMaxColorAttachments,
120 context_type, 122 context_type,
121 new FramebufferCompletenessCache), 123 new FramebufferCompletenessCache),
122 feature_info_(new FeatureInfo()) { 124 feature_info_(new FeatureInfo()) {
123 texture_manager_.reset(new TextureManager(NULL, 125 texture_manager_.reset(new TextureManager(NULL,
124 feature_info_.get(), 126 feature_info_.get(),
125 kMaxTextureSize, 127 kMaxTextureSize,
126 kMaxCubemapSize, 128 kMaxCubemapSize,
127 kMaxRectangleTextureSize, 129 kMaxRectangleTextureSize,
128 kMax3DTextureSize, 130 kMax3DTextureSize,
131 kMaxArrayTextureLayers,
129 kUseDefaultTextures)); 132 kUseDefaultTextures));
130 renderbuffer_manager_.reset(new RenderbufferManager(NULL, 133 renderbuffer_manager_.reset(new RenderbufferManager(NULL,
131 kMaxRenderbufferSize, 134 kMaxRenderbufferSize,
132 kMaxSamples, 135 kMaxSamples,
133 feature_info_.get())); 136 feature_info_.get()));
134 } 137 }
135 ~FramebufferInfoTestBase() override { 138 ~FramebufferInfoTestBase() override {
136 manager_.Destroy(false); 139 manager_.Destroy(false);
137 texture_manager_->Destroy(false); 140 texture_manager_->Destroy(false);
138 renderbuffer_manager_->Destroy(false); 141 renderbuffer_manager_->Destroy(false);
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId); 1186 renderbuffer_manager_->GetRenderbuffer(kRenderbufferClientId);
1184 ASSERT_TRUE(renderbuffer != NULL); 1187 ASSERT_TRUE(renderbuffer != NULL);
1185 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer); 1188 framebuffer_->AttachRenderbuffer(GL_COLOR_ATTACHMENT1, renderbuffer);
1186 EXPECT_TRUE(framebuffer_->GetReadBufferAttachment()); 1189 EXPECT_TRUE(framebuffer_->GetReadBufferAttachment());
1187 } 1190 }
1188 1191
1189 } // namespace gles2 1192 } // namespace gles2
1190 } // namespace gpu 1193 } // namespace gpu
1191 1194
1192 1195
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/context_group.cc ('k') | gpu/command_buffer/service/test_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698