Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 19500022: Reland "Flush parallel recompilation queues on context dispose notification." (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Reland "Flush parallel recompilation queues on context dispose notification." BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15883

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -67 lines) Patch
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/debug.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/heap.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/optimizing-compiler-thread.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 3 chunks +52 lines, -15 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 6 chunks +13 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-prepare-break-while-recompile.js View 1 1 chunk +22 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Second attempt at this. The first patch set is the original CL that has been ...
7 years, 5 months ago (2013-07-25 14:51:53 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/19500022/diff/2001/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/19500022/diff/2001/src/compiler.cc#newcode972 src/compiler.cc:972: PrintF(" ** Compilation queue full, will retry opting ...
7 years, 5 months ago (2013-07-25 14:58:07 UTC) #2
Yang
On 2013/07/25 14:58:07, Jakob wrote: > lgtm > > https://codereview.chromium.org/19500022/diff/2001/src/compiler.cc > File src/compiler.cc (right): > ...
7 years, 5 months ago (2013-07-25 15:01:14 UTC) #3
Yang
7 years, 5 months ago (2013-07-25 15:01:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698