Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/compiler.cc

Issue 19500022: Reland "Flush parallel recompilation queues on context dispose notification." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comment addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 ASSERT(closure->IsMarkedForParallelRecompilation()); 962 ASSERT(closure->IsMarkedForParallelRecompilation());
963 963
964 Isolate* isolate = closure->GetIsolate(); 964 Isolate* isolate = closure->GetIsolate();
965 // Here we prepare compile data for the parallel recompilation thread, but 965 // Here we prepare compile data for the parallel recompilation thread, but
966 // this still happens synchronously and interrupts execution. 966 // this still happens synchronously and interrupts execution.
967 Logger::TimerEventScope timer( 967 Logger::TimerEventScope timer(
968 isolate, Logger::TimerEventScope::v8_recompile_synchronous); 968 isolate, Logger::TimerEventScope::v8_recompile_synchronous);
969 969
970 if (!isolate->optimizing_compiler_thread()->IsQueueAvailable()) { 970 if (!isolate->optimizing_compiler_thread()->IsQueueAvailable()) {
971 if (FLAG_trace_parallel_recompilation) { 971 if (FLAG_trace_parallel_recompilation) {
972 PrintF(" ** Compilation queue, will retry opting on next run.\n"); 972 PrintF(" ** Compilation queue full, will retry optimizing ");
973 closure->PrintName();
974 PrintF(" on next run.\n");
973 } 975 }
974 return; 976 return;
975 } 977 }
976 978
977 SmartPointer<CompilationInfo> info(new CompilationInfoWithZone(closure)); 979 SmartPointer<CompilationInfo> info(new CompilationInfoWithZone(closure));
978 VMState<COMPILER> state(isolate); 980 VMState<COMPILER> state(isolate);
979 PostponeInterruptsScope postpone(isolate); 981 PostponeInterruptsScope postpone(isolate);
980 982
981 Handle<SharedFunctionInfo> shared = info->shared_info(); 983 Handle<SharedFunctionInfo> shared = info->shared_info();
982 int compiled_size = shared->end_position() - shared->start_position(); 984 int compiled_size = shared->end_position() - shared->start_position();
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 // Trace if the appropriate trace flag is set and the phase name's first 1252 // Trace if the appropriate trace flag is set and the phase name's first
1251 // character is in the FLAG_trace_phase command line parameter. 1253 // character is in the FLAG_trace_phase command line parameter.
1252 bool tracing_on = info()->IsStub() ? 1254 bool tracing_on = info()->IsStub() ?
1253 FLAG_trace_hydrogen_stubs : 1255 FLAG_trace_hydrogen_stubs :
1254 FLAG_trace_hydrogen; 1256 FLAG_trace_hydrogen;
1255 return (tracing_on && 1257 return (tracing_on &&
1256 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1258 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1257 } 1259 }
1258 1260
1259 } } // namespace v8::internal 1261 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698