Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/debug.cc

Issue 19500022: Reland "Flush parallel recompilation queues on context dispose notification." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comment addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2026 matching lines...) Expand 10 before | Expand all | Expand 10 after
2037 void VisitThread(Isolate* isolate, ThreadLocalTop* top) { 2037 void VisitThread(Isolate* isolate, ThreadLocalTop* top) {
2038 RedirectActivationsToRecompiledCodeOnThread(isolate, top); 2038 RedirectActivationsToRecompiledCodeOnThread(isolate, top);
2039 } 2039 }
2040 }; 2040 };
2041 2041
2042 2042
2043 void Debug::PrepareForBreakPoints() { 2043 void Debug::PrepareForBreakPoints() {
2044 // If preparing for the first break point make sure to deoptimize all 2044 // If preparing for the first break point make sure to deoptimize all
2045 // functions as debugging does not work with optimized code. 2045 // functions as debugging does not work with optimized code.
2046 if (!has_break_points_) { 2046 if (!has_break_points_) {
2047 if (FLAG_parallel_recompilation) {
2048 isolate_->optimizing_compiler_thread()->Flush();
2049 }
2050
2047 Deoptimizer::DeoptimizeAll(isolate_); 2051 Deoptimizer::DeoptimizeAll(isolate_);
2048 2052
2049 Handle<Code> lazy_compile = 2053 Handle<Code> lazy_compile =
2050 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile)); 2054 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile));
2051 2055
2052 // There will be at least one break point when we are done. 2056 // There will be at least one break point when we are done.
2053 has_break_points_ = true; 2057 has_break_points_ = true;
2054 2058
2055 // Keep the list of activated functions in a handlified list as it 2059 // Keep the list of activated functions in a handlified list as it
2056 // is used both in GC and non-GC code. 2060 // is used both in GC and non-GC code.
(...skipping 1801 matching lines...) Expand 10 before | Expand all | Expand 10 after
3858 { 3862 {
3859 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3863 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3860 isolate_->debugger()->CallMessageDispatchHandler(); 3864 isolate_->debugger()->CallMessageDispatchHandler();
3861 } 3865 }
3862 } 3866 }
3863 } 3867 }
3864 3868
3865 #endif // ENABLE_DEBUGGER_SUPPORT 3869 #endif // ENABLE_DEBUGGER_SUPPORT
3866 3870
3867 } } // namespace v8::internal 3871 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698