Work around a clang-cl devirtualization bug.

Work around a clang-cl devirtualization bug.

clang-cl currently miscompiles calls to virtual methods of base classes
of a final class.  Since the type is final, it tries to devirtualize the call,
but then it forgets to apply the right this adjustment.

https://codereview.chromium.org/1938853002 added static_casts to a super class
for visibility reasons, exposing this bug.

BUG=608705
R=rouslan@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/9306e66e5e680801132688b987fe850f1bb43b7a

[Nico, 2016-05-03 18:12:10]

thakis@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2016-05-03 18:24:33]

lgtm

[Nico, 2016-05-03 18:26:01]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-05-03 18:26:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949653002/20001

[commit-bot: I haz the power, 2016-05-03 18:39:11]

Description was changed from

==========
Work around a clang-cl devirtualization bug.

clang-cl currently miscompiles calls to virtual methods of base classes
of a final class.  Since the type is final, it tries to devirtualize the call,
but then it forgets to apply the right this adjustment.

https://codereview.chromium.org/1938853002 added static_casts to a super class
for visibility reasons, exposing this bug.

BUG=608705
==========

to

==========
Work around a clang-cl devirtualization bug.

clang-cl currently miscompiles calls to virtual methods of base classes
of a final class.  Since the type is final, it tries to devirtualize the call,
but then it forgets to apply the right this adjustment.

https://codereview.chromium.org/1938853002 added static_casts to a super class
for visibility reasons, exposing this bug.

BUG=608705
R=rouslan@chromium.org

Committed: https://crrev.com/9306e66e5e680801132688b987fe850f1bb43b7a
Cr-Commit-Position: refs/heads/master@{#391307}
==========

[commit-bot: I haz the power, 2016-05-03 18:39:12]

Patchset 2 (id:??) landed as
https://crrev.com/9306e66e5e680801132688b987fe850f1bb43b7a
Cr-Commit-Position: refs/heads/master@{#391307}

[Nico, 2016-05-03 18:40:09]

Description was changed from

==========
Work around a clang-cl devirtualization bug.

clang-cl currently miscompiles calls to virtual methods of base classes
of a final class.  Since the type is final, it tries to devirtualize the call,
but then it forgets to apply the right this adjustment.

https://codereview.chromium.org/1938853002 added static_casts to a super class
for visibility reasons, exposing this bug.

BUG=608705
R=rouslan@chromium.org

Committed: https://crrev.com/9306e66e5e680801132688b987fe850f1bb43b7a
Cr-Commit-Position: refs/heads/master@{#391307}
==========

to

==========
Work around a clang-cl devirtualization bug.

clang-cl currently miscompiles calls to virtual methods of base classes
of a final class.  Since the type is final, it tries to devirtualize the call,
but then it forgets to apply the right this adjustment.

https://codereview.chromium.org/1938853002 added static_casts to a super class
for visibility reasons, exposing this bug.

BUG=608705
R=rouslan@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/9306e66e5e680801132688b987fe...
==========

[Nico, 2016-05-03 18:40:10]

Committed patchset #2 (id:20001) manually as
9306e66e5e680801132688b987fe850f1bb43b7a (presubmit successful).

[Nico, 2016-05-09 16:51:42]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1958183002/ by thakis@chromium.org.

The reason for reverting is: We fixed the compiler bug, this should no longer be
needed..