third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 1949653002: Work around a clang-cl devirtualization bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 1949653002: Work around a clang-cl devirtualization bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index 6641cc63ebd3c6fd533c0120d9bd1bbc9eb0ef98..0fd13e06f9df045327b4b1cb900dd24a5528b82a 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -30,7 +30,8 @@ class ScriptPromiseResolver;

class ScriptState;

class ShippingAddress;

-class MODULES_EXPORT PaymentRequest final : public EventTargetWithInlineData, WTF_NON_EXPORTED_BASE(public mojom::blink::PaymentRequestClient), public PaymentCompleter, public ContextLifecycleObserver {

+// TODO(thakis): Make this class final again once https://crbug.com/608705 is fixed.

+class MODULES_EXPORT PaymentRequest /* final */ : public EventTargetWithInlineData, WTF_NON_EXPORTED_BASE(public mojom::blink::PaymentRequestClient), public PaymentCompleter, public ContextLifecycleObserver {

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(PaymentRequest)

WTF_MAKE_NONCOPYABLE(PaymentRequest);

« no previous file with comments | « no previous file | no next file » | no next file with comments »