Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1938853002: More thorough tests for PaymentRequest (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-output-dir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More thorough tests for PaymentRequest - If 'requestShipping' is false, then shippingOption should be null regardless of shipping options passed to PaymentRequest constructor. - An abort() will not throw after show(). - The show() promise is rejected if the shipping address is invalid. - Should not be able to call show() twice. - Should not be able to call complete() twice. - The show() and complete() promises are rejected if the user cancels the payment process. BUG=587995 Committed: https://crrev.com/e1cf4691f10367fe89b124329181957d7e587d53 Cr-Commit-Position: refs/heads/master@{#391077}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 1 5 chunks +187 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
please use gerrit instead
mek@, ptal.
4 years, 7 months ago (2016-05-02 00:40:05 UTC) #3
Marijn Kruisselbrink
https://codereview.chromium.org/1938853002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp (right): https://codereview.chromium.org/1938853002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp#newcode172 third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:172: class MockFunction : public ScriptFunction { Something as generically ...
4 years, 7 months ago (2016-05-02 18:17:41 UTC) #4
please use gerrit instead
mek@, ptal patch 2. https://codereview.chromium.org/1938853002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp (right): https://codereview.chromium.org/1938853002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp#newcode172 third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp:172: class MockFunction : public ScriptFunction ...
4 years, 7 months ago (2016-05-02 21:19:45 UTC) #7
Marijn Kruisselbrink
lgtm
4 years, 7 months ago (2016-05-02 21:22:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938853002/20001
4 years, 7 months ago (2016-05-02 21:30:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 22:33:50 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 22:35:19 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1cf4691f10367fe89b124329181957d7e587d53
Cr-Commit-Position: refs/heads/master@{#391077}

Powered by Google App Engine
This is Rietveld 408576698