Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949603004: [Mac/GN] The info_plist for frameworks goes in Contents/Resources not Contents/. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] The info_plist for frameworks goes in Contents/Resources not Contents/. BUG=297668 R=mark@chromium.org Committed: https://crrev.com/c4426da4139959ef26a0c0dd4493c54a7708d0ea Cr-Commit-Position: refs/heads/master@{#391378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/mac/rules.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 7 months ago (2016-05-03 21:06:05 UTC) #1
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-03 21:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949603004/1
4 years, 7 months ago (2016-05-03 21:07:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 22:24:29 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:25:26 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c4426da4139959ef26a0c0dd4493c54a7708d0ea
Cr-Commit-Position: refs/heads/master@{#391378}

Powered by Google App Engine
This is Rietveld 408576698