build/config/mac/rules.gni - Issue 1949603004: [Mac/GN] The info_plist for frameworks goes in Contents/Resources not Contents/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/rules.gni

Issue 1949603004: [Mac/GN] The info_plist for frameworks goes in Contents/Resources not Contents/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/mac/rules.gni

diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni

index 3c51905d42557e0516bdd08dc4dc8d7ce55cf703..193070f219b43feaa62ffd104f6bab1d5df0166b 100644

--- a/build/config/mac/rules.gni

+++ b/build/config/mac/rules.gni

@@ -166,7 +166,7 @@ template("mac_framework_bundle") {

forward_variables_from(invoker, [ "testonly" ])

sources = get_target_outputs(":$_info_plist_target")

outputs = [

- "{{bundle_root_dir}}/Info.plist",

+ "{{bundle_resources_dir}}/Info.plist",

]

public_deps = [

":$_info_plist_target",

« no previous file with comments | « no previous file | no next file » | no next file with comments »