Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: build/config/mac/rules.gni

Issue 1949603004: [Mac/GN] The info_plist for frameworks goes in Contents/Resources not Contents/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/mac/base_rules.gni") 5 import("//build/config/mac/base_rules.gni")
6 6
7 # Generates Info.plist files for Mac apps and frameworks. 7 # Generates Info.plist files for Mac apps and frameworks.
8 # 8 #
9 # Arguments 9 # Arguments
10 # 10 #
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 "info_plist_target", 159 "info_plist_target",
160 ]) 160 ])
161 } 161 }
162 162
163 _info_plist_bundle_data = _info_plist_target + "_bundle_data" 163 _info_plist_bundle_data = _info_plist_target + "_bundle_data"
164 164
165 bundle_data(_info_plist_bundle_data) { 165 bundle_data(_info_plist_bundle_data) {
166 forward_variables_from(invoker, [ "testonly" ]) 166 forward_variables_from(invoker, [ "testonly" ])
167 sources = get_target_outputs(":$_info_plist_target") 167 sources = get_target_outputs(":$_info_plist_target")
168 outputs = [ 168 outputs = [
169 "{{bundle_root_dir}}/Info.plist", 169 "{{bundle_resources_dir}}/Info.plist",
170 ] 170 ]
171 public_deps = [ 171 public_deps = [
172 ":$_info_plist_target", 172 ":$_info_plist_target",
173 ] 173 ]
174 } 174 }
175 175
176 framework_bundle(target_name) { 176 framework_bundle(target_name) {
177 forward_variables_from(invoker, "*", [ "info_plist" ]) 177 forward_variables_from(invoker, "*", [ "info_plist" ])
178 178
179 if (!defined(deps)) { 179 if (!defined(deps)) {
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 ]) 348 ])
349 if (!defined(deps)) { 349 if (!defined(deps)) {
350 deps = [] 350 deps = []
351 } 351 }
352 deps += [ ":$_loadable_module_bundle_data" ] 352 deps += [ ":$_loadable_module_bundle_data" ]
353 353
354 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents" 354 bundle_root_dir = "$root_out_dir/$_output_name.plugin/Contents"
355 bundle_executable_dir = "$bundle_root_dir/MacOS" 355 bundle_executable_dir = "$bundle_root_dir/MacOS"
356 } 356 }
357 } 357 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698