Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1949303003: Improve indexed gl state related GL commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tex
Patch Set: fix a DCHECK failure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_implementation_impl_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index af9c41dc4a085efc54f417b5ff3d69617fc3d07d..9a294514f056ffbd65008d3ef24ee6bd87f1a16a 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -994,7 +994,6 @@ _NAMED_TYPE_INFO = {
},
'ReadBuffer': {
'type': 'GLenum',
- 'is_complete': True,
'valid': [
'GL_NONE',
'GL_BACK',
@@ -2891,6 +2890,7 @@ _FUNCTION_INFO = {
'FramebufferTextureLayer': {
'decoder_func': 'DoFramebufferTextureLayer',
'unsafe': True,
+ 'unit_test': False,
'trace_level': 1,
},
'GenerateMipmap': {
@@ -3087,13 +3087,19 @@ _FUNCTION_INFO = {
'GetInteger64i_v': {
'type': 'GETn',
'result': ['SizedResult<GLint64>'],
+ 'decoder_func': 'DoGetInteger64i_v',
+ 'shadowed': True,
'client_test': False,
+ 'unit_test': False,
'unsafe': True
},
'GetIntegeri_v': {
'type': 'GETn',
'result': ['SizedResult<GLint>'],
+ 'decoder_func': 'DoGetIntegeri_v',
+ 'shadowed': True,
'client_test': False,
+ 'unit_test': False,
'unsafe': True
},
'GetInternalformativ': {
@@ -8994,8 +9000,6 @@ class EnumBaseArgument(Argument):
return self.named_type.GetConstantValue()
def WriteValidationCode(self, f, func):
- if func.IsUnsafe():
- return
if self.named_type.IsConstant():
return
f.write(" if (!validators_->%s.IsValid(%s)) {\n" %
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_implementation_impl_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698