Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: Source/core/testing/Internals.cpp

Issue 19488002: Introduce toHTMLSelectElement and remove isHTMLSelectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Took Tamura's comment into consideration Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/web/WebSearchableFormData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index a9cf5c51b5f18e846456a954b5e9d5a419329b68..3068d0a5f4a62c6d76b8f9f100382a326803eb01 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -1987,7 +1987,7 @@ String Internals::baseURL(Document* document, ExceptionCode& ec)
bool Internals::isSelectPopupVisible(Node* node)
{
- if (!isHTMLSelectElement(node))
+ if (!node->hasTagName(HTMLNames::selectTag))
return false;
HTMLSelectElement* select = toHTMLSelectElement(node);
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/web/WebSearchableFormData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698