Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 19488002: Introduce toHTMLSelectElement and remove isHTMLSelectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Took Tamura's comment into consideration Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.h
diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h
index 65ab1d5a5dac86f4f931ae260e7a40283b60270b..bcfed462d59572ddbb782630656483eeee1a47ba 100644
--- a/Source/core/html/HTMLSelectElement.h
+++ b/Source/core/html/HTMLSelectElement.h
@@ -206,23 +206,12 @@ private:
bool m_isParsingInProgress;
};
-inline bool isHTMLSelectElement(const Node* node)
-{
- return node->hasTagName(HTMLNames::selectTag);
-}
-
inline HTMLSelectElement* toHTMLSelectElement(Node* node)
{
- ASSERT_WITH_SECURITY_IMPLICATION(!node || isHTMLSelectElement(node));
+ ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::selectTag));
return static_cast<HTMLSelectElement*>(node);
}
-inline const HTMLSelectElement* toHTMLSelectElement(const Node* node)
-{
- ASSERT_WITH_SECURITY_IMPLICATION(!node || isHTMLSelectElement(node));
- return static_cast<const HTMLSelectElement*>(node);
-}
-
void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast.
} // namespace
« no previous file with comments | « no previous file | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698