Source/web/WebSearchableFormData.cpp - Issue 19488002: Introduce toHTMLSelectElement and remove isHTMLSelectElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSearchableFormData.cpp

Issue 19488002: Introduce toHTMLSelectElement and remove isHTMLSelectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Took Tamura's comment into consideration Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSearchableFormData.cpp

diff --git a/Source/web/WebSearchableFormData.cpp b/Source/web/WebSearchableFormData.cpp

index b24489bc77929719365121c8d5b22462213eee18..31bd3ca68a8e1d3176f21d64461047305e1c6e50 100644

--- a/Source/web/WebSearchableFormData.cpp

+++ b/Source/web/WebSearchableFormData.cpp

@@ -143,8 +143,9 @@ bool IsInDefaultState(HTMLFormControlElement* formElement)

const HTMLInputElement* inputElement = toHTMLInputElement(formElement);

if (inputElement->isCheckbox() || inputElement->isRadioButton())

return inputElement->checked() == inputElement->hasAttribute(checkedAttr);

- } else if (formElement->hasTagName(HTMLNames::selectTag))

- return IsSelectInDefaultState(static_cast<HTMLSelectElement*>(formElement));

+ } else if (formElement->hasTagName(HTMLNames::selectTag)) {

+ return IsSelectInDefaultState(toHTMLSelectElement(formElement));

+ }

return true;

}

« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/web/WebSelectElement.cpp » ('j') | no next file with comments »