Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 1948753002: [GN] Cleanup workaround in build/config/ios/rules.gni. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-gen-xcode
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Cleanup workaround in build/config/ios/rules.gni. Remove workaround in build/config/ios/rules.gni now that gn has been rolled to include support for product_type property. BUG=597975 Committed: https://crrev.com/27e8737ee5fbc9cf0b8a2d4a2076cd07030f7096 Cr-Commit-Position: refs/heads/master@{#394116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/config/ios/rules.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
sdefresne
So that I do not forget, let's get this CL ready for after next gn ...
4 years, 7 months ago (2016-05-03 21:11:20 UTC) #2
brettw
lgtm
4 years, 7 months ago (2016-05-03 21:28:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948753002/1
4 years, 7 months ago (2016-05-17 12:59:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 14:02:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 14:04:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e8737ee5fbc9cf0b8a2d4a2076cd07030f7096
Cr-Commit-Position: refs/heads/master@{#394116}

Powered by Google App Engine
This is Rietveld 408576698