build/config/ios/rules.gni - Issue 1948753002: [GN] Cleanup workaround in build/config/ios/rules.gni.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/ios/rules.gni

Issue 1948753002: [GN] Cleanup workaround in build/config/ios/rules.gni. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-gen-xcode

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/ios/rules.gni

diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni

index ebcd7748448cbedd36afe83d7124f70de3297ce2..0a939e7a31545782807681f3f6aa83a1ce8f4310 100644

--- a/build/config/ios/rules.gni

+++ b/build/config/ios/rules.gni

@@ -172,9 +172,6 @@ template("ios_app_bundle") {

bundle_resources_dir = bundle_root_dir

bundle_executable_dir = bundle_root_dir

bundle_plugins_dir = "$bundle_root_dir/Plugins"

- assert(

- product_type != "",

- "workaround to allow generation with version of gn that don't support product_type property for create_bundle target => remove once gn has rolled this change")

}

# TODO(crbug.com/297668):

« no previous file with comments | « no previous file | no next file » | no next file with comments »